Fix pyp2rpm to respect --proxy or env http_proxy/https_proxy… #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure not from this change |
hroncok
reviewed
Aug 13, 2018
| @@ -56,7 +56,37 @@ def __init__(self, package=None, version=None, | |||
| if not self.template.endswith('.spec'): | |||
| self.template = '{0}.spec'.format(self.template) | |||
| self.rpm_name = rpm_name | |||
| self.proxy = proxy | |||
| #check and set proxy settings | |||
There was a problem hiding this comment.
Could this be a function/method on it's own?
There was a problem hiding this comment.
@hroncok I will look at doing that today. I was away on vaca sorry for slow response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyp2rpm doesnt seem to work with HTTP_PROXY or http_proxy or https_proxy or HTTPS_PROXY env variable and also doesn't work with --proxy. So after debugging and testing against a corporate enterprise proxy server I have come up with the following fix.
This fixes the following issue: #24