Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Rhmap 20603 (Bump version of bardcode scanner plugin) #74

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

damienomurchu
Copy link

Jira link

https://issues.jboss.org/browse/RHMAP-20603

What

Bump version of bardcode scanner plugin

Why

Fix failing builds stemming from plugin version

How

Bump version of bardcode scanner plugin from 6.0.0 to 7.1.2

Verification steps

Build project

@jcesarmobile
Copy link
Contributor

jcesarmobile commented May 30, 2018

Just FYI, barcodescanner 7.1.2 requires cordova-android >= 6.3.0 and cordova >= 7.1.0, not sure what are current versions used on the build farms
And we are about to release 8.0.0

@damienomurchu
Copy link
Author

@jcesarmobile nice to hear from you - thanks for the heads-up re the compatibility & the v8.0.0 release. Affected build farms won't be compatible with barcodescanner 7.1.2, and may need to backport your fix here to v6 of barcodescanner to address some build failures

@jcesarmobile
Copy link
Contributor

Instead of porting my commit with the variable, just set the value to a fixed version.
The variable is to configure a version, but I don't think the variables for framework tags will work in your current Cordova version.

@damienomurchu
Copy link
Author

@jcesarmobile thanks - that resolves the issue. We're stuck using cordova 6 with some of our BF's & I thought backporting your commit to v6 of barcodescanner if it added value for others in the same situation - do you think there's another way to do it if variables for framework tags aren't available in cordova 6, or if it would be of value if it was possible?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants