TIP_123: Revoke governance #1097
Conversation
thomas-waite
force-pushed
the
feat/revoke-governance
branch
from
69d5d5f to
16cea85
Compare
tests relied on governor and deprecated contracts
thomas-waite
changed the title
| const tip_123: TemplatedProposalDescription = { | ||
| title: 'TIP_123', | ||
| commands: [ | ||
| // 1. Transfer beneficiary of deprecated Rari FEI timelock to burner timelock |
There was a problem hiding this comment.
TODO: Check everything for which ProxyAdmin is a dependency
TODO: Check all roles Core has ever granted out
There was a problem hiding this comment.
Update: Have checked all roles Core has ever granted out by querying events. Look as expected - permissions.ts config is an exhaustive representation of on-chain state
There was a problem hiding this comment.
Update: Checked all ProxyAdmin dependents. Appears that there were 5 contracts which the proxyAdmin had control over. 2 have since been transferred to Aave's control.
Remaining 3 live are:
- collateralizationOracleWrapper
- tribalChief
- vlAuraDelegatorPCVDeposit
All are fine to deprecate along with the ProxyAdmin. The 2 which have been transferred to Aave are:
- aaveTribeIncentivesController
- balancerGaugeStaker
thomas-waite
force-pushed
the
feat/revoke-governance
branch
from
b783861 to
8e8516c
Compare
thomas-waite
force-pushed
the
feat/revoke-governance
branch
from
8e8516c to
75940a9
Compare
| // expect(await contracts.collateralizationOracle.isOvercollateralized()).to.be.true; | ||
|
|
||
| // 1. Verify Fei DAO timelock admin burned | ||
| expect(await contracts.feiDAOTimelock.admin()).to.equal(addresses.daoTimelockBurner); |
There was a problem hiding this comment.
to be extra safe, would be good to verify that even succeeded votes on the DAO can't be executed. They probably can't even be queued.
Also good to verify that the number of addresses with governor role is 0, there is a method on the OZ AccessControlEnumerated which can check this.
There was a problem hiding this comment.
Verified num GOVERNORs is 0, and also verified num of addresses with other major roles is as expected
There was a problem hiding this comment.
Added test to verify can not queue successful proposals, and therefore can not execute
| }, | ||
|
|
||
| // 2. Transfer beneficiary of deprecated Rari TRIBE timelock to burner timelock | ||
| { |
There was a problem hiding this comment.
The one side effect here is that the TRIBE will remain delegated to Rari Infra multisig as it unlocks. Probably best to do a "delegate(address)(0x0) call" beforehand
thomas-waite
force-pushed
the
feat/revoke-governance
branch
from
52a775f to
cf9d4a8
Compare
thomas-waite
force-pushed
the
feat/revoke-governance
branch
from
c4e0561 to
4abd6f5
Compare
thomas-waite
force-pushed
the
feat/revoke-governance
branch
from
4abd6f5 to
391da85
Compare
thomas-waite
force-pushed
the
feat/revoke-governance
branch
from
f06d561 to
71a5c13
Compare
| @@ -112,172 +69,14 @@ export const MainnetContractsConfig = { | |||
| category: AddressCategory.PCV | |||
There was a problem hiding this comment.
TODO: Deprecate escrowedAaveDaiPCVDeposit after governance removed and Aave has sent funds to the PSM?
| @@ -107,12 +102,6 @@ describe('e2e-metagov', function () { | |||
| ); | |||
| }); | |||
|
|
|||
| it('should revert if contract is paused', async function () { | |||
There was a problem hiding this comment.
why did you remove these test cases?
TIP_123: Revoke governance