Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bloc)!: introduce EmittableStateStreamableSource #4311

Merged
merged 4 commits into from
Jan 1, 2025

Conversation

felangel
Copy link
Owner

@felangel felangel commented Jan 1, 2025

Status

READY

Breaking Changes

YES

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added pkg:bloc This issue is related to the bloc package pkg:bloc_test This issue is related to the bloc_test package breaking change Enhancement candidate would introduce a breaking change refactor Refactor an existing implementation labels Jan 1, 2025
@felangel felangel self-assigned this Jan 1, 2025
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (faada70) to head (e64d2b3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #4311   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          807       807           
=========================================
  Hits           807       807           
Flag Coverage Δ
angular_bloc 100.00% <ø> (ø)
bloc 100.00% <ø> (ø)
bloc_concurrency 100.00% <ø> (ø)
bloc_test 100.00% <ø> (ø)
bloc_tools 100.00% <ø> (ø)
flutter_bloc 100.00% <ø> (ø)
hydrated_bloc 100.00% <ø> (ø)
replay_bloc 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felangel felangel merged commit ed7b27c into master Jan 1, 2025
31 checks passed
@felangel felangel deleted the refactor/bloc-EmittableStateStreamableSource branch January 1, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Enhancement candidate would introduce a breaking change pkg:bloc_test This issue is related to the bloc_test package pkg:bloc This issue is related to the bloc package refactor Refactor an existing implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: bloc_test to depend on core interfaces rather than BlocBase realization
1 participant