refactor: prefer {List,Map}.of over {List,Map}.from
#4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the docs and a few test snippets to use `List.of` and `Map.of` instead of `List.from` and `Map.from`. The `of` factories offer better type-safety by enforcing the collection types at compile-time. Some instances of the `from` factories remain, as they are used for type promotion. To find such cases, run the regex: `(List|Map).*[.]from`. These cases align with Dart's documentation on `Map.from`: > Prefer using Map.of when possible, and only use Map.from to create > a new map with more precise types than the original, and when it's > known that all the keys and values have those more precise types.
tenhobi
approved these changes
Jan 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4333 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 806 806
=========================================
Hits 806 806
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
felangel
approved these changes
Jan 13, 2025
vmichalak
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
Update the docs and a few test snippets to use
List.ofandMap.ofinstead ofList.fromandMap.from. Theoffactories offer better type-safety by enforcing the collection types at compile-time.Some instances of the
fromfactories remain, as they are used for type promotion. To find such cases, run the regex:(List|Map).*[.]from. These cases align with Dart's documentation onMap.from:Type of Change