Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch listener notifications #11

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions core/src/refx/subs.cljc
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,38 @@
(doseq [[_ sub] @sub-cache]
(dispose! sub)))

(defonce ^:private listeners-state
(atom {:counter 0 :pending (sorted-map)}))

(defn- invoke-listener
"This function is responsible for ensuring that signal listeners
(from DynamicSubs) are called before triggering regular listeners
(eg: added via use-sub hook). Listeners are triggered in the order they
were registered. This function ensures that one db update will only trigger
a single render."
[listener-key listener-fn]
(swap! listeners-state (fn [state]
(cond-> (update state :counter inc)
(not (signal? listener-key))
(update :pending assoc listener-key listener-fn))))

(when (signal? listener-key)
(listener-fn))

(interop/next-tick
(fn []
(let [listener-fns (atom nil)]
(swap! listeners-state (fn [state]
(let [{:keys [counter pending] :as new-state}
(update state :counter dec)]
(if (zero? counter)
(do
(reset! listener-fns pending)
(assoc new-state :pending (sorted-map)))
new-state))))
(doseq [[_ f] @listener-fns]
(f))))))

(deftype Listeners [^:mutable listeners]
Object
(empty? [_] (empty? listeners))
Expand All @@ -84,8 +116,8 @@
(remove [_ k]
(set! listeners (dissoc listeners k)))
(notify [_]
(doseq [[_ f] listeners]
(f))))
(doseq [[k f] listeners]
(invoke-listener k f))))

(defn- make-listeners []
(Listeners. nil))
Expand Down