Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several significant changes to the
wicked
project, focusing on migrating frompybind11
tonanobind
, updating the build system, and modifying the installation instructions. The most important changes are categorized into three themes: build system updates, migration tonanobind
, and documentation updates.Build System Updates:
CMakeLists.txt
to require CMake version 3.15...3.26, introducedscikit-build
for building, and added support for finding and usingnanobind
and Boost libraries.pybind11
submodule from.gitmodules
andexternal/pybind11
. [1] [2]wicked/CMakeLists.txt
and integrated them into the mainCMakeLists.txt
.Migration to
nanobind
:pybind11
includes and namespaces withnanobind
in various API files (api_wicked.cc
,combinatorics_api.cc
,equation_api.cc
,expression_api.cc
,index_api.cc
,operator_api.cc
,orbital_space_api.cc
,rational_api.cc
,sqoperator_api.cc
,tensor_api.cc
). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Documentation Updates:
README.md
to usepip install
instead ofsetup.py
.These changes collectively enhance the project's build system, streamline the installation process, and modernize the codebase by migrating to
nanobind
.