Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor errors #135

Merged
merged 2 commits into from
Mar 31, 2021
Merged

refactor errors #135

merged 2 commits into from
Mar 31, 2021

Conversation

drahnr
Copy link
Member

@drahnr drahnr commented Mar 31, 2021 •
edited
Loading

What does this PR accomplish?

Potentially helps to diagnose the cudnn issues.

  • 🩹 Bug Fix
  • 🪣 Misc

Ref #106

Changes proposed by this PR:

Notes to reviewer:

📜 Checklist

  • Test coverage is excellent
  • All unit tests pass
  • The juice-examples run just fine
  • Documentation is thorough, extensive and explicit

@drahnr drahnr requested a review from lissahyacinth March 31, 2021 16:57
@drahnr drahnr force-pushed the bernhard-refactor-errors branch from 89d7bf4 to 261d578 Compare March 31, 2021 16:58
@drahnr drahnr mentioned this pull request Mar 31, 2021
Closed
lissahyacinth
lissahyacinth approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@lissahyacinth lissahyacinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope you didn't have to do this by hand :) LGTM

@drahnr drahnr force-pushed the bernhard-refactor-errors branch from 261d578 to e5291dc Compare March 31, 2021 21:41
@fff-rs fff-rs deleted a comment from GitCop Mar 31, 2021
@fff-rs fff-rs deleted a comment from GitCop Mar 31, 2021
@drahnr
Copy link
Member Author

drahnr commented Mar 31, 2021

Mostly search and replace and a few manual interventions 🙃

@drahnr drahnr merged commit bbdb3ef into master Mar 31, 2021
@drahnr drahnr deleted the bernhard-refactor-errors branch March 31, 2021 22:00
@drahnr drahnr self-assigned this Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lissahyacinth lissahyacinth lissahyacinth approved these changes

Assignees

@drahnr drahnr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drahnr @lissahyacinth