Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Maintain main branch for 1.x.x #20

Merged
merged 7 commits into from
Mar 6, 2025
Merged

[TASK] Maintain main branch for 1.x.x #20

merged 7 commits into from
Mar 6, 2025

Conversation

sbuerk
Copy link
Contributor

@sbuerk sbuerk commented Mar 6, 2025

  • [TASK] Maintain composer.json and ext_emconf.php

    • Set sort-packages: true option in composer.json.
    • Set banch-alias for main to 1.x.x-dev.
    • Minor adjustment of dependencies and development
      dependencies.
    • Align ext_emconf.php dependencies with defined
      dependencies in composer.json.

    Used command(s):

    composer config sort-packages true \
    && composer config extra.banch-alias.dev-main "1.x.x-dev" \
    && composer require --no-update \
      'php':'^8.0 || ^8.1 || ^8.2 || ^8.3' \
      'typo3/cms-core':'^11.5' \
      'fgtclb/academic-persons':'^1.0 || 1.*.*@dev' \
    && composer require --dev --no-update \
      'helhum/typo3-console':'^7.1.6 || ^8.2' \
      'typo3/cms-felogin':'^11.5'
  • [TASK] Streamline GitHub action workflow publish

    The current publish github action workflow is
    streamlined to work in a more smoother way and
    also respect current broken automatic releasing
    with tailor to the TYPO3 Extension Registry.

    This includes:

    • Using a simpler way to get the tag message for
      requested version based on the tag and avoid
      sed issues. Makes the part a little bit more
      obvious.
    • Using tailor to create an upload artifact in
      a first step.
    • Create an github release from the tag using
      the extracted tag message as prepand message
      along with attaching the tailor upload pack
      artifact to the release. If release already
      exists, only the artifact is attached.
    • Try uploading created upload artifact to the
      TER, but do not fail in case it does not work
      yet. Be aware that this must checked manually,
      but attached artifact can simply be used to
      upload it manually to TER mitigating the need
      to build it locally again for the tag.
    • Enhance the README.md to document required
      release workflow for maintainers.
  • [TASK] Mitigate missing TypoScriptFrontendController as request attribute

    It may be possible that the TypoScriptFrontendController is not
    set as frontend.controller request attribute. Use proper fallback
    handling in these cases:

    • Fallback to $GLOBALS['TSFE'].
    • Ensure calls to TSFE methods to deal with the fact that the
      TSFE may not be available even with the global fallback.
  • [TASK] Remove obsolete version from docker-compose

    docker-compose deprecated the version option
    in docker-compose.yml files. To avoid notices
    the option is now removed.

  • [TASK] Streamline v11 testing workflow

    This change streamlines the v11 GitHub action
    workflow.

    • Use checkout@v4 in jobs.
    • Use ubuntu-latest as image.
  • [TASK] Disable functional tests in GitHub workflow

    This extension does not contain any functional
    tests. Disable them in the GitHub workflow.

  • [TASK] Enable unit test in GitHub action workflow

    This extension has unit tests, enable them as CI run.

sbuerk added 2 commits March 6, 2025 13:52
* Set `sort-packages: true` option in `composer.json`.
* Set banch-alias for main to `1.x.x-dev`.
* Minor adjustment of dependencies and development
  dependencies.
* Align `ext_emconf.php` dependencies with defined
  dependencies in `composer.json`.

Used command(s):

```shell
composer config sort-packages true \
&& composer config extra.banch-alias.dev-main "1.x.x-dev" \
&& composer require --no-update \
  'php':'^8.0 || ^8.1 || ^8.2 || ^8.3' \
  'typo3/cms-core':'^11.5' \
  'fgtclb/academic-persons':'^1.0 || 1.*.*@dev' \
&& composer require --dev --no-update \
  'helhum/typo3-console':'^8.0' \
  'typo3/cms-felogin':'^11.5'
```
The current `publish` github action workflow is
streamlined to work in a more smoother way and
also respect current broken automatic releasing
with tailor to the TYPO3 Extension Registry.

This includes:

* Using a simpler way to get the tag message for
  requested version based on the tag and avoid
  sed issues. Makes the part a little bit more
  obvious.
* Using tailor to create an upload artifact in
  a first step.
* Create an github release from the tag using
  the extracted tag message as prepand message
  along with attaching the tailor upload pack
  artifact to the release. If release already
  exists, only the artifact is attached.
* Try uploading created upload artifact to the
  TER, but do not fail in case it does not work
  yet. **Be aware** that this must checked manually,
  but attached artifact can simply be used to
  upload it manually to TER mitigating the need
  to build it locally again for the tag.
* Enhance the `README.md` to document required
  release workflow for maintainers.
sbuerk added 5 commits March 6, 2025 14:02
…bute

It may be possible that the `TypoScriptFrontendController` is not
set as `frontend.controller` request attribute. Use proper fallback
handling in these cases:

* Fallback to `$GLOBALS['TSFE']`.
* Ensure calls to TSFE methods to deal with the fact that the
  TSFE may not be available even with the global fallback.
docker-compose deprecated the `version` option
in `docker-compose.yml` files. To avoid notices
the option is now removed.
This change streamlines the v11 GitHub action
workflow.

* Use `checkout@v4` in jobs.
* Use `ubuntu-latest` as image.
This extension does not contain any functional
tests. Disable them in the GitHub workflow.
This extension has unit tests, enable them as CI run.
@sbuerk sbuerk merged commit e91e56c into main Mar 6, 2025
4 checks passed
@sbuerk sbuerk deleted the stefan-1 branch March 6, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants