Disallow unused variables & imports

fiberplane · Jun 5, 2024 · 40eb83d · 40eb83d
1 parent 1833002
commit 40eb83d
Show file tree

Hide file tree

Showing 9 changed files with 33 additions and 16 deletions.
diff --git a/api/biome.jsonc b/api/biome.jsonc
@@ -1,15 +1,18 @@
 {
   "$schema": "https://biomejs.dev/schemas/1.8.0/schema.json",
   "extends": ["../biome.jsonc"],
-  "css": {
-    "linter": {
-      "enabled": true
-    }
-  },
   "linter": {
     "enabled": true,
     "rules": {
-      "recommended": true
+      "recommended": true,
+      "correctness": {
+        "noUnusedImports": {
+          "level": "error"
+        },
+        "noUnusedVariables": {
+          "level": "error"
+        }
+      }
     }
   },
   "files": {

diff --git a/api/src/lib/find-source-function.ts b/api/src/lib/find-source-function.ts
@@ -79,7 +79,7 @@ async function findFunctionByDefinition(
     });
 
     return foundLocation;
-  } catch (error) {
+  } catch {
     console.error("Error reading or parsing file:", jsFilePath);
     return null;
   }

diff --git a/api/src/lib/utils.ts b/api/src/lib/utils.ts
@@ -7,7 +7,7 @@ export function tryParseJsonObjectMessage(str: unknown) {
   }
   try {
     return JSON.parse(str);
-  } catch (e) {
+  } catch {
     return str;
   }
 }
diff --git a/api/src/routes/issues.ts b/api/src/routes/issues.ts
@@ -1,4 +1,3 @@
-import fs from "node:fs";
 import { githubIssues, newGithubIssueSchema } from "@/db/schema";
 import * as schema from "@/db/schema";
 import type { Bindings, Variables } from "@/lib/types";

diff --git a/api/tsconfig.json b/api/tsconfig.json
@@ -16,6 +16,6 @@
       "@/*": ["src/*"]
     }
   },
-  "include": ["src"],
+  "include": ["src/**/*"],
   "exclude": ["node_modules", "dist", "scripts"]
 }
diff --git a/biome.jsonc b/biome.jsonc
@@ -25,7 +25,15 @@
       "linter": {
         "enabled": true,
         "rules": {
-          "recommended": true
+          "recommended": true,
+          "correctness": {
+            "noUnusedImports": {
+              "level": "error"
+            },
+            "noUnusedVariables": {
+              "level": "error"
+            }
+          }
         }
       }
     },
@@ -37,6 +45,12 @@
     }
   ],
   "files": {
-    "ignore": ["meta/*.json", "dist/*.js", "test-content/*.*", "fpx/*.*"]
+    "ignore": [
+      "meta/*.json",
+      "dist/*.js",
+      "dist/*.d.ts",
+      "test-content/*.*",
+      "fpx/*.*"
+    ]
   }
 }
diff --git a/client-library/src/honoMiddleware.ts b/client-library/src/honoMiddleware.ts
@@ -38,8 +38,9 @@ export function createHonoMiddleware(options: {
       libraryDebugMode,
       monitor: {
         fetch: monitorFetch,
-        logging: monitorLogging,
-        requests: monitorRequests,
+        // TODO - implement these controls/features
+        // logging: monitorLogging,
+        // requests: monitorRequests,
       },
     } = options.createConfig(c);
     const ctx = c.executionCtx;

diff --git a/client-library/src/request-logger.ts b/client-library/src/request-logger.ts
@@ -1,5 +1,5 @@
 import type { Context } from "hono";
-import type { MiddlewareHandler, RouterRoute } from "hono/types";
+import type { RouterRoute } from "hono/types";
 import { getPath } from "hono/utils/url";
 
 export const RECORDED_CONSOLE_METHODS = [

diff --git a/client-library/src/utils.ts b/client-library/src/utils.ts
@@ -29,7 +29,7 @@ export function tryPrettyPrintLoggerLog(fn: PrintFunc, message: string) {
     if (out) {
       fn.apply(fn, [out]);
     }
-  } catch (error) {
+  } catch {
     // Fail silently
   }
 }