Skip to content

Commit

Permalink
Fix the typing of app.fetch for Node envs
Browse files Browse the repository at this point in the history
  • Loading branch information
brettimus committed Sep 1, 2024
1 parent 85e9f96 commit 434c8da
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/client-library-otel/src/instrumentation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export function instrument(app: HonoLikeApp, config?: FpxConfigOptions) {
request: Request,
// Name this "rawEnv" because we coerce it below into something that's easier to work with
rawEnv: HonoLikeEnv,
executionContext: ExecutionContext | undefined,
executionContext?: ExecutionContext,
) {
const env = rawEnv as
| undefined
Expand Down
2 changes: 1 addition & 1 deletion packages/client-library-otel/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export type HonoResponse = Awaited<HonoFetchResult>;
export type HonoLikeFetch = (
request: Request,
env: HonoLikeEnv,
executionContext: ExecutionContext | undefined,
executionContext?: ExecutionContext,
) => HonoFetchResult;
// type HonoLikeFetch = Hono["fetch"];

Expand Down

0 comments on commit 434c8da

Please sign in to comment.