Implement tower layer to propagate trace context #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephlow
approved these changes
Jul 30, 2024
Also return the trace id as part of the response Add trace context to outgoing request going through the API client
Remove obsolete instrument macros
hatchan
force-pushed
the
otel_trace_layer
branch
from
73482ed to
f21fb23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also return the trace id as part of the response
Add trace context to outgoing request going through the API client
Note: The client part is not working as expected. Since it is a shortlived process it won't have time to send any traces that it has buffered. This should be taken care of by
shutdown_tracer_providerbut it doesn't seem to work. Putting a hold on investigating this for now.