Add the ability to replay requests from the details view #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…query is invalidated
|
commit: |
brettimus
reviewed
Aug 27, 2024
studio/src/pages/RequestDetailsPage/RequestDetailsPageV2/RequestDetailsPageV2Content.tsx
Outdated
Show resolved
Hide resolved
brettimus
reviewed
Aug 27, 2024
| enabled: boolean; | ||
| }>, | ||
| ) => { | ||
| const excludedHeaders = [ |
brettimus
reviewed
Aug 27, 2024
| "user-agent", | ||
| "referer", | ||
| "origin", | ||
| "cookie", |
There was a problem hiding this comment.
sure we wanna filter out cookie?
There was a problem hiding this comment.
if someone attached a cookie for example, this breaks auth.
brettimus
reviewed
Aug 27, 2024
|
|
||
| const replayBody = useMemo(() => { | ||
| const body = getRequestBody(span); | ||
| try { |
There was a problem hiding this comment.
no need to refactor, but for future reference, i made a utility for this kind of logic
utility is called isJson, should be importable from the utils module
brettimus
reviewed
Aug 27, 2024
brettimus
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
some flakiness on getting the "view latest" cta to appear for me, but might be specific to running things locally + a stale websocket
only thing that'd be worth considering imo is how to deal with horizontal space on smaller-ish screens, like half of a laptop screen
shorter copy, smaller font, something of the like
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses FP-3855. This PR adds the ability to replay requests from the request details view.
To achieve this, we're adding 3 hooks:
useShouldReplaywhich should gate replayability only to json/text requestsuseReplayRequestwhich enables replaying the requestuseMostRecentRequestwhich informs the UI if the currently viewed request is the most recent oneTODO:
useReplayRequestOf note: we've taken some shortcuts with regards to showing intermediate states while the request is loading or having some more robust interaction patterns in general. This is because there's explorative work in play that if validated will remove the request detail view in general in which case we shouldn't spend too much time on this.