Client library: Use integers in span attributes again #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
brettimus
changed the title
brettimus
force-pushed
the
fp-3989-incorrect-attribute-used-for-http-status-code
branch
from
0e92b2c to
6ef5b6a
Compare
brettimus
force-pushed
the
fp-3989-incorrect-attribute-used-for-http-status-code
branch
2 times, most recently
from
7622f8b to
ee1b8bf
Compare
brettimus
force-pushed
the
fp-3989-incorrect-attribute-used-for-http-status-code
branch
2 times, most recently
from
e026911 to
dd4d05b
Compare
brettimus
force-pushed
the
fp-3989-incorrect-attribute-used-for-http-status-code
branch
from
dd4d05b to
d063b3f
Compare
|
it seems like the otel Rust change has been merged upstream! we can merge this alongside changes to our rusty ingestion piece |
brettimus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert changes from https://github.com/fiberplane/fpx/pull/137/files
Background: The otel rust collector was rejecting certain spans that had integer-values for attributes. We coerced these values to strings to make things work, but it turns out this was a bug in the rust lib.
We need to wait until that bug is resolved and released before updating. Ergo:
DO NOT MERGE UNTIL OTEL-RS HAS THE FOLLOWING PR MERGED AND RELEASED: open-telemetry/opentelemetry-rust#1906