Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScriptCompat* model changes for the Zed extension #216

Closed
wants to merge 12 commits into from

Conversation

keturiosakys
Copy link
Member

@keturiosakys keturiosakys commented Aug 30, 2024

A little hackday experiment creating an extension for Zed to insert trace details into assistant panel context.

UPDATE: the extension has been prepared and published on the Zed extension registry. It needed some changes to the Rust TypeScriptCompat* models that are detailed in this PR. Note, that the Zed extension refers directly to the fpx-lib dep as a git dependency on zed-extension branch, so changes there will need to happen once this is merged.

UPDATE 2: This branch willl not be merged. There's work being done to consolidate all TypescriptCompat* structs in a different PR (#180 ). Keeping this branch open only for the initial release of Zed extension that will need to be updated.

NOTE: it currently makes some slightly terrifying and probably breaking changes to our fpx-lib crates so maybe don't merge as is.

CleanShot.2024-08-30.at.15.23.06.mp4

Copy link

pkg-pr-new bot commented Aug 30, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/fiberplane/fpx/@fiberplane/studio@216
pnpm add https://pkg.pr.new/fiberplane/fpx/@fiberplane/hono-otel@216

commit: 52671d5

@keturiosakys keturiosakys marked this pull request as ready for review September 5, 2024 08:44
@keturiosakys keturiosakys requested a review from a team as a code owner September 5, 2024 08:44
@keturiosakys keturiosakys changed the title Experiment: Zed extension TypeScriptCompat* model changes for the Zed extension Sep 5, 2024
@keturiosakys
Copy link
Member Author

closed in favor of #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant