-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScriptCompat* model changes for the Zed extension #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
keturiosakys
force-pushed
the
zed-extension
branch
from
September 2, 2024 21:57
4a6e035
to
87048eb
Compare
This reverts commit 8202911.
keturiosakys
changed the title
Experiment: Zed extension
TypeScriptCompat* model changes for the Zed extension
Sep 5, 2024
closed in favor of #180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little hackday experiment creating an extension for Zed to insert trace details into assistant panel context.
UPDATE: the extension has been prepared and published on the Zed extension registry. It needed some changes to the Rust TypeScriptCompat* models that are detailed in this PR. Note, that the Zed extension refers directly to the
fpx-lib
dep as a git dependency onzed-extension
branch, so changes there will need to happen once this is merged.UPDATE 2: This branch willl not be merged. There's work being done to consolidate all TypescriptCompat* structs in a different PR (#180 ). Keeping this branch open only for the initial release of Zed extension that will need to be updated.
NOTE: it currently makes some slightly terrifying and probably breaking changes to ourfpx-lib
crates so maybe don't merge as is.CleanShot.2024-08-30.at.15.23.06.mp4