Add issues to request detail page #37
Conversation
Preparing for the PR
|
can you provide steps to trigger a related issue? |
|
probably wanna add some margin between these two cards ( |
|
You can use a script to seed the database with some requests that have related issues (though they don't always really match). The script is rm mizu.db && npm run db:generate && npm run db:migrate && npm run db:seed && npm run devThis removes the current db, runs all the db scripts and starts the server. |
|
|
||
| const paddedChunks = addSurroundingWords(rawChunks, text); | ||
| // const paddedChunks = rawChunks.length ? addSurroundingWords(rawChunks, issue.body) : rawChunks; | ||
| console.log(searchWords); |
| }).filter((chunk) => chunk.highlight); | ||
|
|
||
| const paddedChunks = addSurroundingWords(rawChunks, text); | ||
| // const paddedChunks = rawChunks.length ? addSurroundingWords(rawChunks, issue.body) : rawChunks; |
| if (paddedChunks.length > 0) { | ||
| console.log("before", rawChunks, "after", paddedChunks); | ||
| } | ||
| // return paddedChunks; |
| // const paddedChunks = rawChunks.length ? addSurroundingWords(rawChunks, issue.body) : rawChunks; | ||
| console.log(searchWords); | ||
| if (paddedChunks.length > 0) { | ||
| console.log("before", rawChunks, "after", paddedChunks); |
| } | ||
|
|
||
| if (!issues || issues.length === 0 || !query) { | ||
| return <div>No data</div>; |
There was a problem hiding this comment.
might wanna stylize this a bit, since it seems we'll hit this case quite frequently
There was a problem hiding this comment.
ah i see below (line 48) you actually have a bit of UI for this, but it's unreachable
{issues.length === 0 && (
<li>
<div className="items-center gap-2 justify-center flex text-gray-500">
<ExclamationTriangleIcon />
No related issues found
</div>
</li>
)}|
|
||
| return ( | ||
| <div className="flex flex-row"> | ||
| <Card x-chunk="dashboard-06-chunk-0" className="basis-2/3"> |
There was a problem hiding this comment.
it was there originally so when i was splitting things up into separate components, I moved it. However I will remove it as i don't think it's got any value.
There was a problem hiding this comment.
indeed - i couldn't figure it out. probably something i copy-pasted
There was a problem hiding this comment.
I will remove it in my next PR
| const status = response?.message.status; | ||
| trace.status = typeof status === "string" ? status : "unknown"; | ||
| const size = response?.message.body.length; |
There was a problem hiding this comment.
nice -really improves the requests table!
frontend/src/queries/queries.ts
Outdated
| }); | ||
| const data = await response.json(); | ||
| return GitHubIssuesSchema.parse(data); | ||
| // return data as Array<number>; |
| return GitHubIssuesSchema.parse(data); | ||
| // return data as Array<number>; | ||
| } catch (e: unknown) { | ||
| console.error("Error fetching GitHub issue for a trace: ", e); |
There was a problem hiding this comment.
yeah that makes sense. I didn't think much about it, i was just following the same logic/flow that we already have with fetchMizuLogs. I've added some throws in the code.
| const data = await response.json(); | ||
| return DependenciesSchema.parse(data); | ||
| } catch (e: unknown) { | ||
| console.error("Error fetching dependencies: ", e); |
It also: