Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh artifacts on main #58

Merged
merged 1 commit into from
Nov 27, 2023

Refresh artifacts on main

c1f65c3
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Refresh artifacts on main #58

Refresh artifacts on main
c1f65c3
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / clippy succeeded Nov 24, 2023 in 0s

clippy

1 warning

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 1
Note 0
Help 0

Versions

  • rustc 1.74.0 (79e9716c9 2023-11-13)
  • cargo 1.74.0 (ecb9851af 2023-10-18)
  • clippy 0.1.74 (79e9716 2023-11-13)

Annotations

Check warning on line 136 in providers/cloudwatch/src/client/canonical_request.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `format!` to build up a string from an iterator

warning: use of `format!` to build up a string from an iterator
   --> providers/cloudwatch/src/client/canonical_request.rs:132:31
    |
132 |           let headers: String = self
    |  _______________________________^
133 | |             .headers
134 | |             .iter()
135 | |             .map(|(k, v)| format!("{k}:{v}\n"))
136 | |             .collect::<String>()
    | |________________________________^
    |
help: call `fold` instead
   --> providers/cloudwatch/src/client/canonical_request.rs:135:14
    |
135 |             .map(|(k, v)| format!("{k}:{v}\n"))
    |              ^^^
help: ... and use the `write!` macro here
   --> providers/cloudwatch/src/client/canonical_request.rs:135:27
    |
135 |             .map(|(k, v)| format!("{k}:{v}\n"))
    |                           ^^^^^^^^^^^^^^^^^^^^
    = note: this can be written more efficiently by appending to a `String` directly
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
    = note: `#[warn(clippy::format_collect)]` on by default