Form v2 #146
Merged
Form v2 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The asterisk indicator was not showing up, because FormItems were still using the old flex rules for nesting and diplsaying inputs. Removed the double-nesting hierarchy and it now works again
|
For RadioButtons:
|
When only one Formitem inside a FormItemGroup has helpText, the one without stretches to the height of the Group, causing misalignment of Label and Input. This is fixed by aligning them with the top of the flex item
Previously, only InputFields inside FormItemGroups would stretch to take up equal spaces. Now, any form element inside does the same
…y, and the class wasn’t getting applied
…p area with and prop
- Automatically check for interactivity by looking for onClick/onKeydown etc events and add class to negate the CSS rule - Fix the padding issue where input fields would have 0 padding on the other end when a side element is present
|
Ok this has grown large enough to not be merged. There are still some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.