adds memoization to speed up collection of large dependency trees

filecage · Jul 2, 2019 · 5eac1af · 5eac1af
1 parent e182ffa
commit 5eac1af
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/lib/Dependency.php b/lib/Dependency.php
@@ -34,6 +34,14 @@ class Dependency {
          */
         private $innerDependencies;
 
+        /**
+         * Static memoization of class dependencies to speed up lookups for big trees in larger projects
+         * We're caching by class name as a class can not be overwritten
+         *
+         * @var Dependency[]
+         */
+        static private $dependencies = [];
+
         /**
          * @param \ReflectionFunctionAbstract $reflectionFunction
          * @return \Generator
@@ -62,11 +70,16 @@ static function createFromReflectionParameter(\ReflectionParameter $dependencyPa
             // If the parameter refers to a class, we have to find it's inner dependencies
             if ($type !== null && $type->isBuiltin() === false) {
                 $dependencyClassName = $type->getName();
-                if (!class_exists($dependencyClassName, false)) {
+
+                if (isset(static::$dependencies[$dependencyClassName])) {
+                    return static::$dependencies[$dependencyClassName];
+                } elseif (!class_exists($dependencyClassName, false)) {
                     $dependency = new static(false, $parameterName, $dependencyClassName, null);
                 } else {
                     $dependency = static::createFromCreatable($parameterName, new Creatable($dependencyParameter->getClass()));
+                    static::$dependencies[$dependencyClassName] = $dependency;
                 }
+
             } else {
                 $dependency = new static(true, $parameterName, null, null);
             }