Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fractions in data amounts #220

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

kacperzuk-neti
Copy link
Collaborator

Pull Request Template

Description

Refills fail if there's a fraction in "total requested amount" field.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests

Checklist:

Before submitting your pull request, please review the following checklist:

  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@kacperzuk-neti kacperzuk-neti self-assigned this Jul 25, 2024
@kacperzuk-neti kacperzuk-neti requested a review from Filip-L July 25, 2024 13:10
@kacperzuk-neti kacperzuk-neti force-pushed the hotfix/support-fractions-in-data-amounts branch from 4eae9c3 to 2e10a7b Compare July 25, 2024 13:24
@kacperzuk-neti kacperzuk-neti merged commit 47d35c4 into main Jul 25, 2024
3 checks passed
@kacperzuk-neti kacperzuk-neti deleted the hotfix/support-fractions-in-data-amounts branch July 25, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants