Add endpoint to get the timestamp of the last client auto allocation #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filip-L
deleted the
FIL-232-endpoint-for-fetching-timestamp-of-last-allocation-from-autoallocator
branch
kacperzuk-neti
requested changes
Sep 11, 2024
| use chrono::{DateTime, FixedOffset}; | ||
| use sea_orm::{entity::*, query::*, DbErr}; | ||
|
|
||
| pub async fn get_last_calient_autoallocation( |
There was a problem hiding this comment.
Suggested change
| pub async fn get_last_calient_autoallocation( | |
| pub async fn get_last_client_autoallocation( |
Typo.
| .filter(Column::EvmWalletAddress.contains(client_evm_address.into())) | ||
| .one(&conn) | ||
| .await? | ||
| .ok_or_else(|| DbErr::Custom("Autoallocation not found.".to_string())); |
There was a problem hiding this comment.
Missing autoallocation isn't an error, it will be a relatively normal occurrence.
Returning Error here should be reserved for real errors (db connection issue, db schema mismatch). If there's no autoallocation found, we should return Option::None.
Comment on lines
+6
to
+8
| #[serde(rename = "EVM Wallet Address")] | ||
| pub evm_wallet_address: Address, | ||
| #[serde(rename = "Last Allocation")] |
There was a problem hiding this comment.
Why rename like this?
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| #[derive(Serialize, Deserialize, Debug, Clone)] | ||
| pub struct Autoallocation { |
There was a problem hiding this comment.
What's this struct for, I don't see it used.
Also, why this file is named file.rs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.