[FIL-361] fix: Create separate function to update installation id #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filip-L
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
kacperzuk-neti
approved these changes
Oct 22, 2024
| if installation_id.is_some() { | ||
| allocator_active_model.installation_id = Set(installation_id); | ||
| } | ||
| allocator_active_model.update(&conn).await?; |
There was a problem hiding this comment.
is this an empty update in case installation_id is None ?
There was a problem hiding this comment.
In this case, None means nothing to update so we can't make an empty update
CodeWarriorr
approved these changes
Oct 23, 2024
Filip-L
deleted the
bugfix/FIL-361-overwriting-client-contract-address
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.