[FIL-390] Handle threshold bigger than 2 #244
Open
+83
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filip-L
changed the title
Filip-L
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
Filip-L
force-pushed
the
FIL-390-handle-threshold-bigger-than-2
branch
from
cfb5768
to
49a3975
Compare
Filip-L
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
kacperzuk-neti
requested changes
Nov 14, 2024
| @@ -129,8 +129,8 @@ pub async fn propose( | |||
| ) | |||
| .await | |||
| { | |||
| Ok(app) => HttpResponse::Ok().body(serde_json::to_string_pretty(&app).unwrap()), | |||
| Err(_) => HttpResponse::BadRequest().body("Application is not in the correct state"), | |||
| Ok(_) => HttpResponse::Ok().body(serde_json::to_string_pretty("Success").unwrap()), | |||
There was a problem hiding this comment.
Are we sure this is OK for FE?
| @@ -241,8 +241,8 @@ pub async fn approve( | |||
| ) | |||
| .await | |||
| { | |||
| Ok(app) => HttpResponse::Ok().body(serde_json::to_string_pretty(&app).unwrap()), | |||
| Err(_) => HttpResponse::BadRequest().body("Application is not in the correct state"), | |||
| Ok(_) => HttpResponse::Ok().body(serde_json::to_string_pretty("Success").unwrap()), | |||
There was a problem hiding this comment.
Are we sure this is OK for FE?
Filip-L
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
Filip-L
force-pushed
the
FIL-390-handle-threshold-bigger-than-2
branch
from
218479c
to
33eea61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.