fix(pubsub): Switch to a last-seen cache strategy #12389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
We were using the default first-seen strategy which means we'd loop messages every 2 minutes (when they expire from the cache). This new strategy keeps the message in the cache until we haven't seen it for 2 minutes, ensuring that it eventually drops off the network (with high likelihood).
The downside to this change, and a reason to potentially not include it, is that it may significantly harm message propegation. Specifically:
In practice, we've configured our re-broadcast interval to be greater than the cache time so this may not be an issue? But this still isn't a straight-forward merge.
Additional Info
The correct fix is message expiration: libp2p/go-libp2p-pubsub#573, but that requires deeper protocol changes.
Checklist
Before you mark the PR ready for review, please make sure that: