Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Enhance cancellation handling in methods #16739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IHaidov
Copy link

@IHaidov IHaidov commented Jan 26, 2025

Resolved / Related Issues

Closes #15095

Steps used to test these changes

  • Reviewed all methods to ensure CancellationToken was correctly propagated and utilized where supported.
  • Verified the following scenarios for proper handling of cancellations:
    • Initializing tags using InitAsync.
    • Canceling operations during file tag loading.
    • Canceling long-running operations triggered by commands (e.g., ViewMore, OpenAll).
  • Confirmed that cancellation improved responsiveness without breaking functionality.
  • Tested all affected scenarios for stability, including:
    • Loading file tags and icons.
    • Navigating using the updated commands.
    • Performing various file operations during cancellation scenarios.

Added and propagated CancellationToken in methods to improve operation responsiveness
@yaira2
Copy link
Member

yaira2 commented Jan 27, 2025

@IHaidov thank you for your contribution. We're still reviewing the proposal in #15095 and haven't approved it just yet. We'll look into this shortly and will let you know if we plan to move forward with the proposed changes. For the future, you can view the approval status on the right pane of the issue.

@yaira2 yaira2 requested a review from 0x5bfa January 29, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Quality: Method has overload with cancellation support
2 participants