runtime: runtime scoped spad that replaces wksp and scratch allocations #4028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibhatt-jumptrading
force-pushed
the
runtime_spad
branch
2 times, most recently
from
a747fa2 to
64df671
Compare
ripatel-fd
reviewed
Jan 29, 2025
| if( FD_UNLIKELY( sz>fd_spad_alloc_max( self->spad, FD_SPAD_ALIGN ) ) ) { | ||
| self->failed=1; | ||
| return NULL; | ||
| } |
There was a problem hiding this comment.
Let's add a WARNING log here
ibhatt-jumptrading
force-pushed
the
runtime_spad
branch
2 times, most recently
from
b7c5939 to
7a200b0
Compare
| @@ -736,172 +727,228 @@ typedef struct accounts_hash accounts_hash_t; | |||
| #define MAP_T accounts_hash_t | |||
| #include "../../util/tmpl/fd_map_dynamic.c" | |||
|
|
|||
There was a problem hiding this comment.
The changes here are to support preallocating the buffers so we don't need to dynamically resize while we populate the buffers
src/app/fdctl/run/tiles/fd_batch.c
Outdated
| /* FIXME: Define a bound for the size of the spad. It likely needs to be | ||
| larger than this. */ | ||
| uchar * spad_mem_cur = spad_mem; | ||
| ctx->spad = fd_spad_join( fd_spad_new( spad_mem_cur, 1<<30 /* 1 GiB */ ) ); |
There was a problem hiding this comment.
nit: can we make 1<<30 a macro (also optionally with a comment explaining why we chose this)? so we don't have this duplicated.
src/app/fdctl/run/tiles/fd_replay.c
Outdated
Comment on lines
1219
to
1230
| FD_SPAD_FRAME_BEGIN( ctx->runtime_spad ) { | ||
| fd_txn_p_t * txn = (fd_txn_p_t *)fd_chunk_to_laddr( ctx->sender_out_mem, ctx->sender_out_chunk ); | ||
| fd_tower_to_vote_txn( ctx->tower, ctx->root, vote_bank_hash, vote_block_hash, ctx->validator_identity, ctx->vote_authority, ctx->vote_acc, txn ); | ||
| } FD_SCRATCH_SCOPE_END; | ||
| fd_tower_to_vote_txn( ctx->tower, | ||
| ctx->root, | ||
| vote_bank_hash, | ||
| vote_block_hash, | ||
| ctx->validator_identity, | ||
| ctx->vote_authority, | ||
| ctx->vote_acc, | ||
| txn, | ||
| ctx->runtime_spad ); | ||
| } FD_SPAD_FRAME_END; |
There was a problem hiding this comment.
nit: it might be clearer to move the spad frame setup/teardown inside fd_tower_to_vote_txn, as it's only used by this function. it's only ok to do the setup/teardown here because the allocation is thrown away inside fd_tower_to_vote_txn, so co-locating the logic makes it easier for the reader to understand the lifetime of the allocated memory.
src/flamenco/runtime/fd_runtime.c
Outdated
| /* In order to correctly handle the lifetimes of allocations for partitioned | ||
| epoch rewards, we will push a spad frame when rewards partitioning starts. | ||
| We will only pop this frame when all of the rewards for the epoch have | ||
| been calculated. As a note, this is technically not the most optimal use |
There was a problem hiding this comment.
Suggested change
| been calculated. As a note, this is technically not the most optimal use | |
| been distributed. As a note, this is technically not the most optimal use |
src/app/fdctl/run/tiles/fd_replay.c
Outdated
| there should only be 1 or 2 frames that are on the stack. The first frame | ||
| will hold memory for the slot/epoch context. The potential second frame | ||
| will only exist while rewards are being distributed (around the start of | ||
| an epoch). We pop a frame when rewards are done being calculated */ |
There was a problem hiding this comment.
Suggested change
| an epoch). We pop a frame when rewards are done being calculated */ | |
| an epoch). We pop a frame when rewards are done being distributed. */ |
ibhatt-jumptrading
force-pushed
the
runtime_spad
branch
from
f8ddbf8 to
3ae0a2f
Compare
ibhatt-jumptrading
changed the title
mjain-jump
approved these changes
Feb 3, 2025
ibhatt-jumptrading
force-pushed
the
runtime_spad
branch
from
b9370db to
4702ea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of wksp and scratch allocations. Starting to remove the use of valloc in the runtime. Adding runtime scoped spad.
DOES NOT: