flamenco: no more custom votes anywhere #4202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibhatt-jumptrading
changed the title
topointon-jump
previously approved these changes
Feb 13, 2025
src/flamenco/stakes/fd_stakes.c
Outdated
| // Insert into the temporary vote states cache | ||
| fd_vote_info_pair_t_mapnode_t * new_vote_state_node = fd_vote_info_pair_t_map_acquire( temp_info->vote_states_pool ); | ||
| fd_memcpy( &new_vote_state_node->elem.account, vote_account_pubkey, sizeof(fd_pubkey_t) ); | ||
| fd_memcpy( &new_vote_state_node->elem.state, vote_state, sizeof(fd_vote_state_versioned_t) ); | ||
| fd_vote_info_pair_t_map_insert( temp_info->vote_states_pool, &temp_info->vote_states_root, new_vote_state_node ); | ||
| } else { | ||
| FD_LOG_NOTICE(("WHATS HAPPENING HERE")); |
src/flamenco/stakes/fd_stakes.c
Outdated
| @@ -347,13 +345,15 @@ fd_refresh_vote_accounts( fd_exec_slot_ctx_t * slot_ctx, | |||
| fd_pubkey_t const * vote_account_pubkey = &elem->elem.key; | |||
| fd_vote_state_versioned_t vote_state[1] = {0}; | |||
| if( FD_LIKELY( !deserialize_and_update_vote_account( slot_ctx, elem, root, pool, vote_account_pubkey, vote_state, runtime_spad ) ) ) { | |||
| FD_TEST( vote_state->inner.current.epoch_credits ); | |||
Comment on lines
+2379
to
+2396
| switch( vsv->discriminant ) { | ||
| case fd_vote_state_versioned_enum_v0_23_5: | ||
| node_pubkey = vsv->inner.v0_23_5.node_pubkey; | ||
| last_ts_slot = vsv->inner.v0_23_5.last_timestamp.slot; | ||
| break; | ||
| case fd_vote_state_versioned_enum_v1_14_11: | ||
| node_pubkey = vsv->inner.v1_14_11.node_pubkey; | ||
| last_ts_slot = vsv->inner.v1_14_11.last_timestamp.slot; | ||
| break; | ||
| case fd_vote_state_versioned_enum_current: | ||
| node_pubkey = vsv->inner.current.node_pubkey; | ||
| last_ts_slot = vsv->inner.current.last_timestamp.slot; | ||
| break; | ||
| default: | ||
| __builtin_unreachable(); | ||
| } | ||
|
|
There was a problem hiding this comment.
might be nice in future prs to define getters for these fields, possibly in fd types
ibhatt-jumptrading
force-pushed
the
no_more_custom_votes
branch
from
ff19b92 to
a7a3645
Compare
topointon-jump
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.