Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in fd_neigh4_probe.h #4221

Merged
merged 1 commit into from
Feb 13, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/waltz/neigh/fd_neigh4_probe.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

If no matching neighbor table entry exists, the system should send
broadcast an ARP request (e.g. "who is 192.168.12.13? tell
192.168.12.4"). ARP relies to this request will then go to the
192.168.12.4"). ARP replies to this request will then go to the
kernel. The kernel also needs to be told that it should expect an
ARP reply to avoid drops.

Expand All @@ -26,15 +26,16 @@
`ip neigh add IP_ADDR nud incomplete`
Requires CAP_NET_ADMIN (to send RTM_NEWNEIGH)

2. Add a neighbor table entry, make the kernel increase the ARP
2. Add a neighbor table entry, make the kernel issue the ARP
request: `ip neigh add IP_ADDR nud incomplete use`
Requires CAP_NET_ADMIN (to send RTM_NEWNEIGH)

3. Send a UDP datagram, which indirectly makes the kernel do an ARP
3. Send a UDP datagram which indirectly makes the kernel do an ARP
request: `echo "hello" | nc -u IP_ADDR:65535`
Does not require privileges

4. Send an IP packet (ICMP echo, invalid ICMP, invalid next proto...)
which indirectly makes the kernel do an ARP request
`ping IP_ADDR -c 1`
Requires CAP_NET_RAW to create a SOCK_RAW socket

Expand Down
Loading