-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for changes to firedrake.assemble
default behaviour.
#212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ImplicitMatrixContext for the bc nodes
JHopeCollins
added
bug
Something isn't working
Core functionality
Adding to the main paradiag functionality
upstream
Issue related to upstream dependencies
labels
Jan 17, 2025
…ro_bc_nodes=True) fixes through
… implementation more thoroughly, and simplify vector implementation DirichletBCs'
colinjcotter
approved these changes
Jan 20, 2025
can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
Core functionality
Adding to the main paradiag functionality
PRIORITY
Needs urgent attention
upstream
Issue related to upstream dependencies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour of
firedrake.assemble
was changed in #3947. Dirichlet bc nodes are now automatically zeroed, you can't switch this off without an error, and you can no longer pass aFunction
as the tensor, only aCofunction
.This PR updates asQ to deal with this.
Essentially, we now deal with boundary conditions in essentially the same way as firedrake:
AllAtOnceForm
will now:a) Enforce the boundary conditions on the
AllAtOnceFunction
before calculating the residual.b) Set the residual to 0 at all
DirichletBC
nodes.c) Only accept an
AllAtOnceCofunction
for thetensor
argument (previously it would accept a compatibleAllAtOnceFunction
,PETSc.Vec
, orfiredrake.Function
for thetensor
argument).AllAtOneJacobian.mult
will do the same thing asfiredrake.ImplicitMatrixContext
, i.e. it will leave the bc nodes untouched, and also ignore their effect on the rest of the nodes.Other changes to note:
HybridisationSCPC
that we use to apply hybridisation to thecomplex_proxy
block forms is broken, in that the test LVS solves diverge. I have xfailed the tests for now so that we can merge the fixes to the main library, and opened FixHybridisationSCPC
afterassemble(..., zero_bc_nodes=True)
updates. #213 to fix it urgently.assemble
changes I think we can merge if these are the only test failures.