Adding firedrake_adjoint tests from pyadjoint #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Ig-dolci
commented
Feb 10, 2025
|
Why are the tests being moved? |
connorjward
approved these changes
Feb 10, 2025
@connorjward suggested this option since we do not have any Firedrake code within pyadjoint. I also prefer keeping Firedrake/adjoint tests within Firedrake itself. We still seek to have firedrake/adjoints tests checked in the pyadjoint CI. |
|
Just had a chat with Connor about it. Sounds like the right thing to do, thanks for taking it on. |
|
I will include this PR in the coming Firedrake meeting to keep everyone informed. |
connorjward
force-pushed
the
dolci/move_pyadjoint_tests_to_firedrake
branch
from
ee97c0a to
9a30d4d
Compare
|
I have just rebased this PR so that all tests should now pass. |
dham
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move
firedrake_adjointtests from pyadjoint totests/firedrake/adjoint. I also movedtest_ensemble_reduced_functional/test_ensemble_reduced_functional.pytotests/firedrake/adjoint.