Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy examples #410

Merged
merged 21 commits into from
Jul 28, 2023
Merged

Tidy examples #410

merged 21 commits into from
Jul 28, 2023

Conversation

jshipton
Copy link
Contributor

The aim of this PR is to reduce the run time of the tests while retaining sufficient coverage of functionality.

  • edit the thermal shallow water example to run for just one timestep when running via pytest
  • reduce spatial resolution of DCMIP test when running via pytest
  • remove some examples that duplicate functionality tested by running other examples - these will go to the case studies repository

tommbendall and others added 21 commits July 24, 2023 21:31
@tommbendall
begin reorganising function spaces
40e8baf
@tommbendall
further work on function spaces
f253414
evaluate physics at each stage of SSPRK3, RK4 and Heun's method
a92fc04
@tommbendall
make whole de rham complex
6146c05
@tommbendall
fix replace_perp test
79aa19c
evaluate the source term at x1 instead of x_in at each stage
47068db
use a SplitPhysicsTimestepper in the InstantRain test with RK4 for ph…
97f48a5 
…ysics (and make the tolerance more slack) and note that we need to update this test when we have a CoupledAdvectionEquation
make lint
a6bc71a
@tommbendall
Merge branch 'main' into de_rham_complex
abf52d1
@tommbendall
Merge branch 'main' into timestepping_physics
866e46a
@tommbendall
Merge branch 'main' into timestepping_physics
b1aa590
@tommbendall
Merge branch 'main' into de_rham_complex
df80704
@tommbendall
Merge pull request #399 from firedrakeproject/timestepping_physics
9fcd77a 
PR #399: Evaluate physics at each stage of multistep methods
@tommbendall
Merge branch 'main' into de_rham_complex
f12882c
@jshipton
Merge pull request #402 from firedrakeproject/de_rham_complex
f054fd4 
Build the whole de Rham complex in the domain
@jshipton
make thermal shallow water run for just one timestep when run from tests
9a452dd
@jshipton
shorten dcmip example when run from tests
d9eac58
@jshipton
rename example
782448c
@jshipton
remove a couple of examples
86d4d8e
@jshipton
Merge branch 'main' of https://github.com/firedrakeproject/gusto into…
63cd94b 
… tidy_examples
@jshipton
Merge branch 'JDBetteridge/time_CI' into tidy_examples
b3e92c1
tommbendall
tommbendall approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@tommbendall tommbendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thanks! We can now move the deleted examples to our case_studies

@tommbendall tommbendall merged commit 5b140cb into JDBetteridge/time_CI Jul 28, 2023
4 checks passed
@tommbendall tommbendall deleted the tidy_examples branch July 28, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommbendall tommbendall tommbendall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jshipton @tommbendall