Log the Courant number #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The DG0 Courant number based on DG fluxes is a bit more useful for pinpointing exactly which cell things went bad in. |
Oh interesting, thanks Colin! How would we go about calculating that? |
Looks like your code is already set up to do it. You just set the output space to a DG0 |
jshipton
reviewed
Aug 24, 2023
gusto/io.py
Outdated
| number of. Defaults to 'u'. | ||
| expression (:class:`ufl.Expr`, optional): expression of velocity | ||
| field to take Courant number of. Defaults to None, in which case | ||
|
|
jshipton
reviewed
Aug 24, 2023
| state_fields (:class:`StateFields`): the model's field container. | ||
| name (str, optional): the name of the field to log the Courant | ||
| number of. Defaults to 'u'. | ||
| message (str, optional): an extra message to be logged. Defaults to |
There was a problem hiding this comment.
I like the option to add a message!
jshipton
requested changes
Aug 24, 2023
jshipton
approved these changes
Aug 24, 2023
|
On 24 Aug 2023, at 15:26, David A. Ham ***@***.***> wrote:
Looks like your code is already set up to do it. You just set the output space to a DG0 FunctionSpace.
Message ID: ***@***.***>
No, it’s different.
See: https://github.com/firedrakeproject/asQ/blob/master/utils/diagnostics.py<https://github.com/firedrakeproject/asQ/blob/master/utils/diagnostics.py>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a system to log the Courant number, which will be done by default.
Main points:
log_courantoption is passed to the output configurationCourantNumberdiagnostic is augmented so that it can be evaluated on an expression, and not just the field named "u" (this is used when the transporting velocity isn't exactly the wind field)SemiImplicitQuasiNewtontime stepper logs the Courant number every outer loop