Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A package of idealised physics routines #425

Merged
merged 44 commits into from
Oct 24, 2023
Merged

A package of idealised physics routines #425

merged 44 commits into from
Oct 24, 2023

Conversation

tommbendall
Copy link
Contributor

@tommbendall tommbendall commented Aug 23, 2023

This PR adds a package of idealised physics routines, that are largely taken from the DCMIP (2016) test case documentation.

  1. A general SourceSink physics scheme, which takes some expression and evaluates it as a source or sink of a variable.
  2. A SurfaceFlux scheme, which allows prescribed surface fluxes to be applied to theta and water vapour.
  3. A WindDrag scheme.
  4. A StaticAdjustment scheme
  5. A BoundaryLayerMixing scheme

Additionally it implements a Firedrake "escape hatch", allowing us to break out of the standard structure of Firedrake Functions and to handle column-wise data instead. This is the only way to implement some physics schemes (such as dry static adjustment) and opens the route to us doing other non-FEM algorithms in the future.

Lots of other features have been pulled off this branch and brought onto main through separate PRs, but this branch still includes:

  • a bit of a hack to allow ExplicitMultiStage schemes to work when there is no right-hand side

@tommbendall tommbendall marked this pull request as ready for review October 8, 2023 19:06
Copy link
Contributor

@jshipton jshipton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor comments - this opens up a lot of cool stuff!

gusto/coordinates.py Outdated Show resolved Hide resolved
gusto/coordinates.py Outdated Show resolved Hide resolved
gusto/logging.py Outdated Show resolved Hide resolved
gusto/timeloop.py Outdated Show resolved Hide resolved
gusto/timeloop.py Outdated Show resolved Hide resolved
gusto/physics.py Outdated Show resolved Hide resolved
gusto/physics.py Outdated Show resolved Hide resolved
@jshipton jshipton merged commit d4e14ec into main Oct 24, 2023
4 checks passed
@jshipton jshipton deleted the physics_package branch October 24, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants