-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A package of idealised physics routines #425
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abels to physics schemes
…ogging statements
jshipton
requested changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few minor comments - this opens up a lot of cool stuff!
jshipton
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a package of idealised physics routines, that are largely taken from the DCMIP (2016) test case documentation.
SourceSink
physics scheme, which takes some expression and evaluates it as a source or sink of a variable.SurfaceFlux
scheme, which allows prescribed surface fluxes to be applied to theta and water vapour.WindDrag
scheme.StaticAdjustment
schemeBoundaryLayerMixing
schemeAdditionally it implements a Firedrake "escape hatch", allowing us to break out of the standard structure of Firedrake
Function
s and to handle column-wise data instead. This is the only way to implement some physics schemes (such as dry static adjustment) and opens the route to us doing other non-FEM algorithms in the future.Lots of other features have been pulled off this branch and brought onto main through separate PRs, but this branch still includes:
ExplicitMultiStage
schemes to work when there is no right-hand side