Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Courant number calculation #610

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Courant number calculation #610

wants to merge 1 commit into from

Conversation

tommbendall
Copy link
Contributor

Fixes the Courant number calculation which is breaking tests following this Firedrake PR: firedrakeproject/firedrake#3947

@tommbendall tommbendall added the bug Pull requests or issues to relating to something not working label Jan 20, 2025
@tommbendall
Copy link
Contributor Author

tommbendall commented Jan 20, 2025 •
edited
Loading

Unfortunately there seem to be other failures here...

  1. boundary_layer_mixing tests are failing with ufl.algorithms.check_arities.ArityMismatch

  2. test_zero_limiter.py and some thermal shallow water tests, failing with a petsc error in the linear solve

  3. test_moist_compressible, test_dry_compressible, test_simultaneous_SIQN (order 1), test_boussinesq.py (compressible) all failing with changed KGOs

  4. test_tracer_conservative_transport no longer passing consistent transport test

@tommbendall tommbendall added the external issue Pull requests or issues relating to an external issue label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Pull requests or issues to relating to something not working external issue Pull requests or issues relating to an external issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tommbendall