Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use checkpointed mesh in defining parameters for KGO checking tests #622

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Use checkpointed mesh in defining parameters for KGO checking tests #622

merged 2 commits into from
Mar 10, 2025

Conversation

tommbendall
Copy link
Contributor

Fixes the currently failing two KGO tests. Not sure how this was passing last week!

@tommbendall tommbendall added the fixes Involves changes to fix something that is broken label Mar 10, 2025
jshipton
jshipton approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@jshipton jshipton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for spotting this! just waiting for tests to pass then will merge...

@tommbendall tommbendall merged commit c895753 into main Mar 10, 2025
4 checks passed
@tommbendall tommbendall deleted the TBendall/FixCIMultipleDomains branch March 10, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshipton jshipton jshipton approved these changes

Assignees
No one assigned
Labels
fixes Involves changes to fix something that is broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommbendall @jshipton