Merge remote-tracking branch 'upstream/main' into ksagiyam/merge_upst…

…ream
firedrakeproject · Nov 14, 2024 · e7803b0 · e7803b0
2 parents 949c823 + d835011
commit e7803b0
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/ufl/pullback.py b/ufl/pullback.py
@@ -560,7 +560,7 @@ def physical_value_shape(self, element, domain) -> typing.Tuple[int, ...]:
         Returns:
             The value shape when the pull back is applied to the given element
         """
-        raise NotImplementedError()
+        return element.reference_value_shape
 
 
 class CustomPullback(AbstractPullback):
@@ -598,9 +598,7 @@ def physical_value_shape(self, element, domain) -> typing.Tuple[int, ...]:
         Returns:
             The value shape when the pull back is applied to the given element
         """
-        if element.reference_value_shape == ():
-            return ()
-        raise NotImplementedError()
+        return element.reference_value_shape
 
 
 class UndefinedPullback(AbstractPullback):
@@ -628,7 +626,7 @@ def physical_value_shape(self, element, domain) -> typing.Tuple[int, ...]:
         Returns:
             The value shape when the pull back is applied to the given element
         """
-        raise NotImplementedError()
+        return element.reference_value_shape
 
 
 identity_pullback = IdentityPullback()