initial version #228
Draft
initial version #228
+1,896
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i want to refactor this to use the fixie SDK after it supports list agent conversations.
mdwelsh
approved these changes
Jan 25, 2024
petersalas
reviewed
Jan 31, 2024
| const response = await axios({ | ||
| method: 'get', | ||
| maxBodyLength: Infinity, | ||
| url: `https://api.fixie.ai/api/v1/agents/${agentId}/conversations`, |
There was a problem hiding this comment.
Is this endpoint paginated?
There was a problem hiding this comment.
yes it is. changed the implementation to handle paging.
| numTokens += encoded.length; | ||
|
|
||
| numConvoChars += message.response.length; | ||
| numConvoTokens += encoded.length; |
There was a problem hiding this comment.
This ignores the quadratic effect where messages become input tokens to subsequent generations (e.g. a conversation with 10 messages uses >> 10 times the number of input tokens as a conversation with 1 message)
But old messages also get pruned as well as they fill up the context window, so calculating it accurately is even trickier. The easiest thing to get approximately correct is to calculate the number of output tokens, because that's just the assistant text/functionCall messages, but I'm guessing you want an estimate for both :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i want to refactor this to use the fixie SDK after it supports list agent conversations.