Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pseudonymization of list elements and allow regex of list elements in auto-tests #284

Merged
merged 7 commits into from
Feb 15, 2023

Conversation

ppcad
Copy link
Collaborator

@ppcad ppcad commented Jan 11, 2023

Pseudonymize list elements instead of converting the list into a string before pseudonymization.
Extend the auto-tester to have tests with regex list elements.

@ppcad ppcad self-assigned this Jan 11, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 90.71% // Head: 90.93% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (f48cca8) compared to base (0a7d729).
Patch coverage: 94.52% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   90.71%   90.93%   +0.22%     
==========================================
  Files         114      115       +1     
  Lines        7786     7856      +70     
==========================================
+ Hits         7063     7144      +81     
+ Misses        723      712      -11     
Impacted Files Coverage Δ
logprep/processor/pseudonymizer/processor.py 98.17% <89.47%> (-0.39%) ⬇️
...rep/util/auto_rule_tester/grok_pattern_replacer.py 95.04% <95.04%> (ø)
logprep/run_logprep.py 92.90% <100.00%> (ø)
logprep/util/auto_rule_tester/auto_rule_tester.py 87.15% <100.00%> (ø)
logprep/framework/pipeline_manager.py 100.00% <0.00%> (ø)
logprep/runner.py 97.24% <0.00%> (+0.09%) ⬆️
logprep/util/log_aggregator.py 100.00% <0.00%> (+1.72%) ⬆️
logprep/_version.py 39.71% <0.00%> (+2.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ppcad ppcad requested review from Malutthias and ekneg54 January 26, 2023 07:39
Copy link
Collaborator

@Malutthias Malutthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like fine wine - approved

@ppcad ppcad marked this pull request as ready for review February 9, 2023 13:48
@ppcad ppcad marked this pull request as draft February 9, 2023 14:02
@ppcad ppcad marked this pull request as ready for review February 14, 2023 13:13
@ekneg54
Copy link
Collaborator

ekneg54 commented Feb 15, 2023

resolved merge conflicts because it has to be merged before rewrite of pseudonymizer in #306

@ekneg54 ekneg54 merged commit d6cf592 into main Feb 15, 2023
@ekneg54 ekneg54 deleted the dev-pseudonymize-list-elements branch March 10, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants