Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/multi placeholder and struct args #108

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

zeroXbrock
Copy link
Member

  • feat: add uni v3 scenario

Fixed some bugs in the templating engine: structs as tuples were not supported. You can flatten tuples to get a signature that still works, so now we flatten function signatures with tuples (e.g. function set(uint x, (uint y, uint z)) becomes function set(uint x, uint y, uint z). The only modification needed to the UniV3 example was to flatten the args passed. The generator still expects the args to match the signature, and now that it's flattened, the args have to match that. But I think this is a fair compromise; it's easier to read when looking at args directly.

  • fix arg replacement index bug in templater
  • update packages
  • flatten struct (tuple) args in fn sig to parse correctly
  • flatten UniV3 scenario args

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants