bugfix/multi placeholder and struct args #108
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some bugs in the templating engine: structs as tuples were not supported. You can flatten tuples to get a signature that still works, so now we flatten function signatures with tuples (e.g.
function set(uint x, (uint y, uint z))
becomesfunction set(uint x, uint y, uint z)
. The only modification needed to the UniV3 example was to flatten the args passed. The generator still expects the args to match the signature, and now that it's flattened, the args have to match that. But I think this is a fair compromise; it's easier to read when looking at args directly.