Add support for Electra #651
Conversation
Yes, I'm planning to add tests later. Please hold off on merging this for a little bit. We're working on getting the whole Electra builder stack working in Kurtosis this week. Thank you for reviewing though 😄 I'm fairly confident in these mev-boost changes, but mev-boost-relay will need some more work. |
|
Waiting for attestantio/go-eth2-client#163 |
|
|
||
| require ( | ||
| github.com/ethereum/go-ethereum v1.14.7 | ||
| github.com/flashbots/go-boost-utils v1.8.1 | ||
| github.com/ethereum/go-ethereum v1.14.9 |
There was a problem hiding this comment.
minor: I'd suggest bumping to 1.14.13 while we're updating.
| @@ -125,6 +126,41 @@ func blindedBlockContentsToPayloadDeneb(signedBlindedBlockContents *eth2ApiV1Den | |||
| } | |||
| } | |||
|
|
|||
| func blindedBlockContentsToPayloadElectra(signedBlindedBlockContents *eth2ApiV1Electra.SignedBlindedBeaconBlock) *builderApiDeneb.ExecutionPayloadAndBlobsBundle { | |||
There was a problem hiding this comment.
shouldn't this return *builderApiElectra instead of builderApiDeneb?
There was a problem hiding this comment.
Nah because there is no new ExecutionPayloadAndBlobsBundle in Electra.
| "transactions_root": "0xb1fcd304d8ba402be6e76346395ea7641fbb4c83663b697a0e88ab115d859d3f", | ||
| "withdrawals_root": "0x792930bbd5baac43bcc798ee49aa8185ef76bb3b44ba62b91d86ae569e4bb535", | ||
| "blob_gas_used": "0", | ||
| "excess_blob_gas": "0" |
There was a problem hiding this comment.
Isn't this missing ParentBeaconRoot and RequestHash ?
There was a problem hiding this comment.
Hmm I don't think so. I believe you're thinking of NewPayloadRequest.
| func (m *BoostService) processElectraPayload(w http.ResponseWriter, req *http.Request, log *logrus.Entry, blindedBlock *eth2ApiV1Electra.SignedBlindedBeaconBlock) { | ||
| // Get the currentSlotUID for this slot | ||
| currentSlotUID := "" | ||
| m.slotUIDLock.Lock() |
There was a problem hiding this comment.
I think we can get away with an RLock here
There was a problem hiding this comment.
Or make SlotUID an atomic
There was a problem hiding this comment.
I will do this in a follow-up
📝 Summary
This PR adds support for Electra payloads.
⛱ Motivation and Context
✅ I have run these commands
make lintmake test-racego mod tidy