Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linter issues #707

Merged
merged 8 commits into from
Dec 10, 2024
Merged

fix linter issues #707

merged 8 commits into from
Dec 10, 2024

Conversation

0xTylerHolmes
Copy link
Contributor

📝 Summary

The following PR modifies the golangci.yml config to work with the latest golang-cli.

  1. Remove references to deprecated and disabled linters.
  2. It also adds nolint comments where necessary.
  3. Modify some tests to adhere to linters

⛱ Motivation and Context

Fixes linting warnings


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @0xTylerHolmes!

@jtraglia
Copy link
Collaborator

@metachris I'm going to merge this. It should be uncontroversial, but please review retroactively.

@jtraglia jtraglia merged commit 19b2788 into flashbots:develop Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants