Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update FAQ to reflect low priority of backfill tasks on dramatiq #293

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pintail-xyz
Copy link
Contributor

@pintail-xyz pintail-xyz commented Apr 23, 2022

What does this PR do?

Commit 1fbecbe changed the priority of worker tasks on dramtiq, so the FAQ instructions for redis need updating.

Related issue

294

Testing

I tested these commands on my own system. With default priority, no messages were returned. With low priority, all the expected messages about running backfill tasks were returned.

Checklist before merging

  • Read the contributing guide
  • Installed and ran pre-commit hooks
  • All tests pass with ./mev test

Copy link
Contributor

@gheise gheise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you'd like to add the high priority as well, feel free to! Thanks for catching this by the way, very helpful. We are looking to improve our documentation as time permits

```

For messages failed and waiting to retry in the delay queue (DQ), query:
```
HGETALL dramatiq:default.DQ.msgs
HGETALL dramatiq:low.DQ.msgs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In reality, tasks sent from the listener are high priority, while tasks queued manually are low priority, so there are two delay queues and X queues.

DEL dramatiq:default.msgs
DEL dramatiq:default.DQ.msgs
DEL dramatiq:low.msgs
DEL dramatiq:low.DQ.msgs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same applies here: deleting backfill tasks:
DEL "dramatiq:low.msgs"
deleting listener tasks:
DEL "dramatiq:high.msgs"

@@ -141,23 +141,23 @@ To see progress and failed batches, connect to Redis with

For total messages, query:
```
HLEN dramatiq:default.msgs
HLEN dramatiq:low.msgs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing quotes around the ZSET, "dramatiq:low.msgs"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants