Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Avoid CoinGecko's API rate limit with time delays, when updating prices #331

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Mar 16, 2023

  1. Avoid CoinGecko's API rate limit with time delays

    Updating token prices with ./mev prices fetch-all can fail due to CoinGecko's API rate limits https://www.coingecko.com/en/api/pricing_2 (10-30 requests a minute)
    
    Error message:
    ValueError: {'status': {'error_code': 429, 'error_message': "You've exceeded the Rate Limit. Please visit https://www.coingecko.com/en/api/pricing to subscribe to our API plans for higher rate limits."}}
    
    Currently, TOKEN_ADDRESSES length is 14 which can (and does) fail the function, depending on the dynamic limit
    
    By introducing time delays between API queries we can avoid hitting the limit and failing the price update.
    romandvo authored Mar 16, 2023
    Configuration menu
    Copy the full SHA
    5cdbf5b View commit details
    Browse the repository at this point in the history