Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tracing #27

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Add Tracing #27

merged 2 commits into from
Oct 30, 2024

Conversation

avalonche
Copy link
Collaborator

@avalonche avalonche commented Oct 25, 2024 •
edited
Loading

WIP, waiting for issues to resolve as described in #25.

Jaeger tracing UI:
Screenshot 2024-10-25 at 6 01 10 PM

@avalonche avalonche changed the title Tracing Add Tracing Oct 25, 2024
@avalonche avalonche marked this pull request as ready for review October 29, 2024 11:50
ferranbt
ferranbt requested changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@ferranbt ferranbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the dependency comment, LGTM!

Cargo.toml Outdated Show resolved Hide resolved
@avalonche avalonche merged commit 044fdd3 into main Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferranbt ferranbt ferranbt approved these changes

@liamaharon liamaharon Awaiting requested review from liamaharon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avalonche @ferranbt