Refactor tests to reduce repetition and use py.test over nose. #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nose has been deprecated for several years whereas py.test is still under active development. As a result it is more accepted nowadays to use py.test as the test runner. This refactor also reduces much of the repetition in the tests and moves to the functional style of testing favoured by py.test.
|
Ok I'll look at upping the coverage a bit today 😇 |
|
@joshfriend what is the crypto lib used? I have tests for that module but don't know what lib is being used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nose has been deprecated for several years whereas py.test is still
under active development. As a result it is more accepted nowadays to
use py.test as the test runner.
This refactor also reduces much of the repetition in the tests and moves
to the functional style of testing favoured by py.test.