Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated s3 and cloudfront docs #26793

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated s3 and cloudfront docs #26793

wants to merge 1 commit into from
+2 −2

Conversation

ksykulev
Copy link
Contributor

@ksykulev ksykulev commented Mar 3, 2025

In server/config/config.go the S3Config expects differently named yaml keywords for the cloudfront public and private key values.

https://github.com/fleetdm/fleet/blob/main/server/config/config.go#L330-L332

	SoftwareInstallersCloudFrontURL                   string        `yaml:"software_installers_cloudfront_url"`
	SoftwareInstallersCloudFrontURLSigningPublicKeyID string        `yaml:"software_installers_cloudfront_url_signing_public_key_id"`
	SoftwareInstallersCloudFrontURLSigningPrivateKey  string        `yaml:"software_installers_cloudfront_url_signing_private_key"`

@ksykulev
Updated s3 and cloudfront docs
9921a09 
In `server/config/config.go` the `S3Config` expects differently named yaml keywords
for the cloudfront public and private key values.
@ksykulev ksykulev requested review from getvictor and rfairburn March 3, 2025 23:56
rfairburn
rfairburn approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@rfairburn rfairburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Terraform module worked when using the changed values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getvictor getvictor getvictor approved these changes

@rfairburn rfairburn rfairburn approved these changes

@Drew-P-drawers Drew-P-drawers Awaiting requested review from Drew-P-drawers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksykulev @getvictor @rfairburn