Cherry pick: Clear cron schedule errors before each run (#26775) #26798
+36
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For #26657 This PR fixes an issue that causes cron monitoring alerts to be sent repeatedly after the first instance; that is, if a cron job fails once then the monitor reports the failure every time it runs until the server is restarted. This was due to the errors being held in the Schedule object which persists for the lifetime of the process, rather than being recreated for each run. The solution is to clear the errors from the Schedule object before each run. Added a test that fails on main and passes on this branch.
iansltx
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking this into next release to quiet error alerts, as per thread here
For #26657