Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching of parsed CVE feeds during vulncheck hydration, don't save revised feeds until hydration is complete #26801

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Mar 4, 2025

On my local, this gets us a differential vulns feed update (for this part of it) in under 90 seconds, vs. taking on the order of...40 minutes, I think? RAM usage is a few GB, but we have headroom on GitHub Actions and the performance increase is worth it.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

…e revised feeds until hydration is complete

On my local, this gets us a differential vulns feed update (for this part of it) in under 90 seconds, vs. taking on the order of...40 minutes, I think? RAM usage is a few GB, but we have headroom on GitHub Actions and the performance increase is worth it.
@iansltx iansltx requested a review from a team as a code owner March 4, 2025 07:20
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.97%. Comparing base (e2152cd) to head (9569e97).

Files with missing lines Patch % Lines
server/vulnerabilities/nvd/sync/cve_syncer.go 72.72% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26801      +/-   ##
==========================================
- Coverage   63.99%   63.97%   -0.03%     
==========================================
  Files        1695     1695              
  Lines      161583   161643      +60     
  Branches     4300     4300              
==========================================
+ Hits       103405   103409       +4     
- Misses      50153    50206      +53     
- Partials     8025     8028       +3     
Flag Coverage Δ
backend 64.74% <72.72%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants