Skip to content

Commit

Permalink
Improve messaging around failures (#22)
Browse files Browse the repository at this point in the history
The `job.status` is the status of the freshness check, which will always
`success`. Change it to a hard coded `failure` to avoid confusion.
Also link to the workflow runs page filtered on "failure" to provide a
quick link to diagnose the issue.
  • Loading branch information
ksykulev authored Feb 25, 2025
1 parent ff07f02 commit 2a00f59
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/cve-freshness-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,13 @@ jobs:
with:
payload: |
{
"text": "${{ job.status }}\n${{ github.event.pull_request.html_url || github.event.head.html_url }}",
"text": "failure\n${{ github.event.pull_request.html_url || github.event.head.html_url }}",
"blocks": [
{
"type": "section",
"text": {
"type": "mrkdwn",
"text": "<!subteam^S086VL144TU>, security artifacts generation result: ${{ job.status }}\nhttps://github.com/fleetdm/vulnerabilities/actions/runs/${{ github.run_id }}\n${{ github.event.pull_request.html_url || github.event.head.html_url }}"
"text": "<!subteam^S086VL144TU>, security artifacts generation result: failure\nhttps://github.com/fleetdm/vulnerabilities/actions/runs/${{ github.run_id }}\nSee https://github.com/fleetdm/vulnerabilities/actions?query=is%3Afailure for failure details\n${{ github.event.pull_request.html_url || github.event.head.html_url }}"
}
}
]
Expand Down

0 comments on commit 2a00f59

Please sign in to comment.