Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll cold start fix #795

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Poll cold start fix #795

merged 6 commits into from
Feb 5, 2025

Conversation

jnunemaker
Copy link
Collaborator

It's possible if using an adapter that doesn't retain state that a feature could be checked before the first background thread sync finishes. If this happens flipper thinks no features are enabled. That's not good. So let's avoid that by forcing a sync in the main thread.

Should we rescue around the sync and warn? Probably?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@jnunemaker jnunemaker requested a review from bkeepers December 17, 2023 22:06
@jnunemaker jnunemaker self-assigned this Dec 17, 2023
@jnunemaker
Copy link
Collaborator Author

Looks like I have failures to deal with first because the tests don't like doing the sync.

Now they all try to do a sync so let's make the get_all more flexible and stub the rest.
@jnunemaker jnunemaker merged commit ff3d9d3 into main Feb 5, 2025
92 checks passed
@jnunemaker jnunemaker deleted the poll-cold-start-fix branch February 5, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant